Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove our specific branch from installation of cffconvert. #199

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Remove our specific branch from installation of cffconvert. #199

merged 3 commits into from
Nov 15, 2023

Conversation

led02
Copy link
Member

@led02 led02 commented Aug 2, 2023

No description provided.

@led02 led02 linked an issue Aug 2, 2023 that may be closed by this pull request
Switch back to upstream CFF-Convert #197
Closed
@led02 led02 marked this pull request as draft August 2, 2023 13:49
@led02
Fix tests to work with updated CFFConvert semantics
bf70a2d 
As a bonus, I made the test email address RFC 6761 compliant
@led02
Copy link
Member Author

led02 commented Aug 3, 2023

Now, this works again... But:

  1. There is no new version published yet, hence we still need to install from Repository.
  2. Semantics seem to have changed (see bf70a2d).

Hence, I have no strong opinion on whether this should be merged or "kept for later"...

@led02 led02 marked this pull request as ready for review August 3, 2023 13:23
@led02 led02 added bug Something isn't working question Further information is requested meeting-discussion Issues that should be discussed at the next project meeting 1️ harvesting The harvesting step in the workflow labels Aug 3, 2023
poikilotherm
poikilotherm approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for fixing the tests!

@poikilotherm poikilotherm merged commit 04b66a4 into develop Nov 15, 2023
3 checks passed
@poikilotherm poikilotherm deleted the feature/197-upstream-cff-convert branch November 15, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poikilotherm poikilotherm poikilotherm approved these changes

@sdruskat sdruskat Awaiting requested review from sdruskat

Assignees
No one assigned
Labels
1️ harvesting The harvesting step in the workflow bug Something isn't working meeting-discussion Issues that should be discussed at the next project meeting question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch back to upstream CFF-Convert
2 participants
@led02 @poikilotherm